-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable relation between glossary term and datasets searchable #2806
Conversation
@@ -7,5 +7,10 @@ record GlossaryTermAssociation { | |||
/** | |||
* Urn of the applied glossary term | |||
*/ | |||
@Searchable = { | |||
"fieldName": "glossaryTerms", | |||
"fieldType": "TEXT_PARTIAL", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets make the fieldType URN_PARTIAL- it parses urns more correctly than TEXT_PARTIAL does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lalrishav it looks like a comment you added may have been deleted- are you still planning on using TEXT_PARTIAL instead of TEXT_URN as a temporary fix for partial term searches?
yes can we do that pls ? as a temporary fix .
@Searchable = { | ||
"fieldName": "glossaryTerms", | ||
"fieldType": "TEXT_PARTIAL", | ||
"hasValuesFieldName": "hasTerms" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you expect to use the hasTerms
filter? This filters datasets by those that have terms vs those that don't. How would you imagine this query being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no we dont need hasTerms, will remove it
@lalrishav it looks like a comment you added may have been deleted- are you still planning on using TEXT_PARTIAL instead of TEXT_URN as a temporary fix for partial term searches? |
@saxo-lalrishav looks like you need to re-run gradle build and commit the newly generated avro schemas |
@saxo-lalrishav bump- you need to re-run gradle build and commit the newly generated avro schemas for CI to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Checklist