Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) default browse path for glossary term #2788

Merged
merged 5 commits into from
Jul 16, 2021
Merged

(fix) default browse path for glossary term #2788

merged 5 commits into from
Jul 16, 2021

Conversation

saxo-lalrishav
Copy link
Contributor

@saxo-lalrishav saxo-lalrishav commented Jun 29, 2021 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@saxo-lalrishav
Copy link
Contributor Author

#2787

gabe-lyons
gabe-lyons reviewed Jul 1, 2021
View reviewed changes
metadata-models/src/main/pegasus/com/linkedin/metadata/aspect/GlossaryTermAspect.pdl
typeref GlossaryTermAspect = union[GlossaryTermKey, GlossaryTermInfo, Ownership, Status,BrowsePaths]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a space after Status, for consistency

@gabe-lyons
Copy link
Contributor

@saxo-lalrishav looks like you need to re-run gradle build and commit the newly generated avro schemas

shirshanka
shirshanka approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit ae014bf into datahub-project:master Jul 16, 2021
@saxo-lalrishav saxo-lalrishav mentioned this pull request Jul 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saxo-lalrishav @gabe-lyons @shirshanka