Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): print Docker logs on timeout #2743

Merged
merged 2 commits into from
Jun 23, 2021
Merged

feat(ingest): print Docker logs on timeout #2743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a2cdc4
Add finally
kevinhu Jun 22, 2021
1697f54
Add comment
kevinhu Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions metadata-ingestion/tests/test_helpers/docker_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,16 @@ def wait_for_port(
container_port: int,
timeout: float = 30.0,
) -> None:
# port = docker_services.port_for(container_name, container_port)
docker_services.wait_until_responsive(
timeout=timeout,
pause=0.5,
check=lambda: is_responsive(container_name, container_port),
)
try:
# port = docker_services.port_for(container_name, container_port)
docker_services.wait_until_responsive(
timeout=timeout,
pause=0.5,
check=lambda: is_responsive(container_name, container_port),
)
finally:
# use check=True to raise an error if command gave bad exit code
subprocess.run(f"docker logs {container_name}", shell=True, check=True)


@pytest.fixture
Expand Down