Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Fixes current user entity not being populated correctly #1880

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

cptran777
Copy link
Contributor

Summary

Because of differences in the midtier for the current user /me api, we created a workaround that doesn't necessarily populate the current user's entity object correctly. This was expected to not have a significant impact on the operation of the application, however it turns out the ownership tab in datasets depends on the logged in user's entity object to validate ownership selections. As such, we went back and looked into how this object is being populated and see that we can simply make a second API call to populate the full information.

Testing done

Locally tested.

Manually tested with docker images to ensure that application builds and behaves as expected for sample data

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@cptran777 cptran777 merged commit 3b7eb08 into master Sep 18, 2020
@cptran777 cptran777 deleted the fe-ownership-ui-fix branch September 18, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants