Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (frontend): Partially fixes lineage issues and dataset API handling #1874

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

cptran777
Copy link
Contributor

This PR fixes the following issues:

Both of which likely stem from the same root cause: that the datasets response for the open source midtier (datahub-frontend) no longer matches with how we are handling datasets in datahub-web internally. This PR doesn't create a perfect parity between the two but should bring us a little closer to how components are currently consuming dataset data.

Upon testing, it looks like the lineage issue is solved and other components are currently working fine.

Screen Shot 2020-09-14 at 3 40 06 PM

Will rely on automated tests with the build for the rest.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@igbopie
Copy link
Contributor

igbopie commented Sep 15, 2020

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants