Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Pushing internal consolidation of modules to open source #1835

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

cptran777
Copy link
Contributor

@cptran777 cptran777 commented Aug 28, 2020

This PR contains more logic to consolidate modules on the FE to improve build times and provide a smaller/cleaner repo.

No issues are directly addressed by this PR, but the cleanup process is continuing here and follow up changes will start addressing issues as well as provide cleaner OS implementations.

Testing done:

Tested by running changes on local docker image and confirming that changes did not affect current application build and behavior.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@cptran777 cptran777 merged commit 0116a95 into master Aug 28, 2020
@cptran777 cptran777 deleted the fe-module-consolidation branch August 28, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants