Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata-models 54.0.1 -> 58.0.1 #1610

Merged
merged 1 commit into from
Mar 27, 2020
Merged

metadata-models 54.0.1 -> 58.0.1 #1610

merged 1 commit into from
Mar 27, 2020

Conversation

jywadhwani
Copy link
Contributor

Changes include:
Remove all keys that can be moved back to respective GMS
Add support for <, <=, >, >= conditions for the filter API
Update Conditions model for <, <=, >, >= conditions

MP_VERSION=metadata-models:58.0.1
MP_VERSION=wherehows-samza:1.0.56

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Changes include:
Remove all keys that can be moved back to respective GMS
Add support for <, <=, >, >= conditions for the filter API
Update Conditions model for <, <=, >, >= conditions

MP_VERSION=metadata-models:58.0.1
MP_VERSION=wherehows-samza:1.0.56
Copy link
Contributor

@keremsahin1 keremsahin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Keep those PRs coming!

@jywadhwani jywadhwani merged commit 5fb3c97 into master Mar 27, 2020
@jywadhwani jywadhwani deleted the developer-jyoti branch March 27, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants