Drop LI internal fabrics #1581
Merged
Drop LI internal fabrics #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars-lan
force-pushed
the
mars-lan-patch-1
branch
from
3327d0b to
c526926
Compare
keremsahin1
suggested changes
Mar 2, 2020
| "AZURECONTROL": "Designates production fabrics deployed in the Azure control plane.", | ||
| "AZUREPROD": "Designates production fabrics deployed in the Azure.", | ||
| "AZUREEI": "Designates Early-Integration fabrics deployed in Azure." | ||
| "DEV": "Designates DEV fabrics", |
There was a problem hiding this comment.
Maybe change DEV with development?
datahub-web/@datahub/metadata-types/addon/constants/common/fabric-type.ts
Outdated
Show resolved
Hide resolved
keremsahin1
reviewed
Mar 2, 2020
gms/api/src/main/snapshot/com.linkedin.dataset.datasets.snapshot.json
Outdated
Show resolved
Hide resolved
keremsahin1
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These enums are for internal use and are causing confusion in open source