fix(lineage): error message for edit lineage

[anshbansal]

• show proper error message in case user does not have privilege on upstream
• change some log.debug(String.format to log.debug( on java side
• move copying war to later as rest of items are less frequently changed. Will very slightly help with dev workflow for gms
• add note that you need privilege on both upstream and downstream entity when editing lineage.

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
1872	1	1871	41

View the full list of 1 ❄️ flaky tests

tests.cypress.integration_test::test_run_cypress

Flake rate in main: 11.11% (Passed 32 times, Failed 4 times)

Stack Traces | 886s run time

auth_session = <tests.utils.TestSessionWrapper object at 0x7ff64e169870>

    def test_run_cypress(auth_session):
        # Run with --record option only if CYPRESS_RECORD_KEY is non-empty
        record_key = os.getenv("CYPRESS_RECORD_KEY")
        tag_arg = ""
        test_strategy = os.getenv("TEST_STRATEGY", None)
        if record_key:
            record_arg = " --record "
            batch_number = os.getenv("BATCH_NUMBER")
            batch_count = os.getenv("BATCH_COUNT")
            if batch_number and batch_count:
                batch_suffix = f"-{batch_number}{batch_count}"
            else:
                batch_suffix = ""
            tag_arg = f" --tag {test_strategy}{batch_suffix}"
        else:
            record_arg = " "
    
        print(f"test strategy is {test_strategy}")
        test_spec_arg = ""
        specs_str = ",".join([f"**/{f}" for f in _get_cypress_tests_batch()])
        test_spec_arg = f" --spec '{specs_str}' "
    
        print("Running Cypress tests with command")
        command = f"NO_COLOR=1 npx cypress run {record_arg} {test_spec_arg} {tag_arg}"
        print(command)
        # Add --headed --spec '**/mutations/mutations.js' (change spec name)
        # in case you want to see the browser for debugging
        print_now()
        proc = subprocess.Popen(
            command,
            shell=True,
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
            cwd=f"{CYPRESS_TEST_DATA_DIR}",
        )
        assert proc.stdout is not None
        assert proc.stderr is not None
        stdout = proc.stdout.read()
        stderr = proc.stderr.read()
        return_code = proc.wait()
        print(stdout.decode("utf-8"))
        print("stderr output:")
        print(stderr.decode("utf-8"))
        print("return code", return_code)
        print_now()
>       assert return_code == 0
E       assert 1 == 0

tests/cypress/integration_test.py:250: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[chriscollins3456]

i don't know about this flow so not sure if you want to run this by anyone else or if you feel confident

[chriscollins3456]

nice