Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix token to be not required in sample script #12511

Merged
merged 1 commit into from
Jan 31, 2025
Merged

docs: fix token to be not required in sample script #12511

merged 1 commit into from
Jan 31, 2025

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Jan 31, 2025 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

allows ingestion without tokens when token-based authentication is disabled.

locally tested and it worked fine

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 31, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 31, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1524 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e88ae...d21799b. Read the comment docs.

@yoonhyejin yoonhyejin requested a review from hsheth2 January 31, 2025 00:34
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 31, 2025
@yoonhyejin yoonhyejin merged commit 301d628 into datahub-project:master Jan 31, 2025
218 of 257 checks passed
eagle-25 pushed a commit to eagle-25/datahub that referenced this pull request Feb 12, 2025
@yoonhyejin @eagle-25
docs: fix token to be not required in sample script (datahub-project#…
739f018 
…12511)
eagle-25 pushed a commit to eagle-25/datahub that referenced this pull request Feb 17, 2025
@yoonhyejin @eagle-25
docs: fix token to be not required in sample script (datahub-project#…
ee6a4b3 
…12511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@ryota-cloud ryota-cloud Awaiting requested review from ryota-cloud

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoonhyejin @hsheth2