Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingestion/dbt): Add include_database_name parameter for dbt core #12411

Merged
merged 8 commits into from
Feb 11, 2025
Merged

feat(ingestion/dbt): Add include_database_name parameter for dbt core #12411

merged 8 commits into from
Feb 11, 2025

Conversation

svdimchenko
Copy link
Contributor

@svdimchenko svdimchenko commented Jan 21, 2025 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable): it partially resolves AWS Glue and Athena reengineering #12410
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 21, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 21, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...ion/src/datahub/ingestion/source/dbt/dbt_common.py 91.53% <100.00%> (+0.01%) ⬆️
...stion/src/datahub/ingestion/source/dbt/dbt_core.py 87.40% <ø> (ø)

... and 15 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6098e97...c011aa2. Read the comment docs.

@svdimchenko svdimchenko force-pushed the fix/dbt-athena-catalog branch from 9a99f64 to 0c0d8e6 Compare January 22, 2025 11:36
@svdimchenko svdimchenko changed the title feat: Add skip_database_name parameter for dbt core feat(dbt-core): Add skip_database_name parameter for dbt core Jan 22, 2025
@svdimchenko svdimchenko changed the title feat(dbt-core): Add skip_database_name parameter for dbt core feat(ingestion/dbt): Add skip_database_name parameter for dbt core Jan 22, 2025
@KulykDmytro
Copy link
Contributor

nice job!!!

@svdimchenko
Copy link
Contributor Author

@hsheth2 hi there! Could you please take a look at this PR?

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 29, 2025
@jackson-burke jackson-burke mentioned this pull request Jan 29, 2025
Open
5 tasks
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Feb 4, 2025
@svdimchenko svdimchenko changed the title feat(ingestion/dbt): Add skip_database_name parameter for dbt core feat(ingestion/dbt): Add include_database_name parameter for dbt core Feb 4, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Feb 5, 2025
@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Feb 5, 2025
@svdimchenko
Copy link
Contributor Author

Hey @sgomezvillamor ! I see the docker pipeline is failed due to smoke tests error. However my PR does not introduce any changes there. Can we merge this PR ?

@sgomezvillamor sgomezvillamor merged commit 20409fd into datahub-project:master Feb 11, 2025
187 of 190 checks passed
ksrinath pushed a commit to ksrinath/datahub that referenced this pull request Feb 14, 2025
@svdimchenko @ksrinath
feat(ingestion/dbt): Add include_database_name parameter for dbt core (…
fd1a3c6 
…datahub-project#12411)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 3, 2025
@svdimchenko @shirshanka
feat(ingestion/dbt): Add include_database_name parameter for dbt core (…
736912f 
…datahub-project#12411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svdimchenko @KulykDmytro @sgomezvillamor