Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: fix pre-commit passing filenames incorrectly #12304

Merged
merged 2 commits into from
Jan 9, 2025
Merged

dev: fix pre-commit passing filenames incorrectly #12304

merged 2 commits into from
Jan 9, 2025

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Jan 9, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

@anshbansal anshbansal merged commit 42b2cd3 into master Jan 9, 2025
73 of 74 checks passed
@anshbansal anshbansal deleted the ab-2025-jan-09-error-pre-commit-fix branch January 9, 2025 12:58
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@anshbansal @llance
dev: fix pre-commit passing filenames incorrectly (datahub-project#12304
5ad7c5f 
)
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@anshbansal @llance
dev: fix pre-commit passing filenames incorrectly (datahub-project#12304
b9ebedf 
)
brock-acryl pushed a commit to brock-acryl/datahub that referenced this pull request Jan 30, 2025
@anshbansal @chakru-r
dev: fix pre-commit passing filenames incorrectly (datahub-project#12304
4960b4a 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @pedro93