Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk/patch): improve patch implementation internals #12253

Merged
merged 11 commits into from
Jan 2, 2025
+535 −992

fix codecov flags

d9153ab
Select commit
Loading
Failed to load commit list.
Merged

refactor(sdk/patch): improve patch implementation internals #12253

fix codecov flags
d9153ab
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 2, 2025 in 1s

80.26% of diff hit (target 57.05%)

View this Pull Request on Codecov

80.26% of diff hit (target 57.05%)

Annotations

Check warning on line 274 in metadata-ingestion/src/datahub/emitter/mce_builder.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/emitter/mce_builder.py#L274 

Added line #L274 was not covered by tests

Check warning on line 37 in metadata-ingestion/src/datahub/emitter/mcp_patch_builder.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/emitter/mcp_patch_builder.py#L37 

Added line #L37 was not covered by tests

Check warning on line 52 in metadata-ingestion/src/datahub/specific/aspect_helpers/custom_properties.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/custom_properties.py#L51-L52 

Added lines #L51 - L52 were not covered by tests

Check warning on line 58 in metadata-ingestion/src/datahub/specific/aspect_helpers/custom_properties.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/custom_properties.py#L58 

Added line #L58 was not covered by tests

Check warning on line 45 in metadata-ingestion/src/datahub/specific/aspect_helpers/ownership.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/ownership.py#L45 

Added line #L45 was not covered by tests

Check warning on line 51 in metadata-ingestion/src/datahub/specific/aspect_helpers/ownership.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/ownership.py#L51 

Added line #L51 was not covered by tests

Check warning on line 64 in metadata-ingestion/src/datahub/specific/aspect_helpers/ownership.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/ownership.py#L64 

Added line #L64 was not covered by tests

Check warning on line 67 in metadata-ingestion/src/datahub/specific/aspect_helpers/ownership.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/ownership.py#L67 

Added line #L67 was not covered by tests

Check warning on line 30 in metadata-ingestion/src/datahub/specific/aspect_helpers/structured_properties.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/structured_properties.py#L28-L30 

Added lines #L28 - L30 were not covered by tests

Check warning on line 42 in metadata-ingestion/src/datahub/specific/aspect_helpers/structured_properties.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/structured_properties.py#L42 

Added line #L42 was not covered by tests

Check warning on line 48 in metadata-ingestion/src/datahub/specific/aspect_helpers/structured_properties.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/structured_properties.py#L48 

Added line #L48 was not covered by tests

Check warning on line 63 in metadata-ingestion/src/datahub/specific/aspect_helpers/structured_properties.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/structured_properties.py#L63 

Added line #L63 was not covered by tests

Check warning on line 72 in metadata-ingestion/src/datahub/specific/aspect_helpers/structured_properties.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/structured_properties.py#L72 

Added line #L72 was not covered by tests

Check warning on line 42 in metadata-ingestion/src/datahub/specific/aspect_helpers/tags.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/tags.py#L39-L42 

Added lines #L39 - L42 were not covered by tests

Check warning on line 24 in metadata-ingestion/src/datahub/specific/aspect_helpers/terms.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/terms.py#L24 

Added line #L24 was not covered by tests

Check warning on line 27 in metadata-ingestion/src/datahub/specific/aspect_helpers/terms.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/terms.py#L27 

Added line #L27 was not covered by tests

Check warning on line 40 in metadata-ingestion/src/datahub/specific/aspect_helpers/terms.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/terms.py#L38-L40 

Added lines #L38 - L40 were not covered by tests

Check warning on line 43 in metadata-ingestion/src/datahub/specific/aspect_helpers/terms.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/aspect_helpers/terms.py#L43 

Added line #L43 was not covered by tests

Check warning on line 47 in metadata-ingestion/src/datahub/specific/chart.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/chart.py#L47 

Added line #L47 was not covered by tests

Check warning on line 45 in metadata-ingestion/src/datahub/specific/datajob.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/datajob.py#L45 

Added line #L45 was not covered by tests

Check warning on line 10 in metadata-ingestion/src/datahub/specific/form.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/form.py#L10 

Added line #L10 was not covered by tests

Check warning on line 14 in metadata-ingestion/src/datahub/specific/form.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/specific/form.py#L14 

Added line #L14 was not covered by tests
View more details on Codecov