Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(businessAttribute): generate platform events on association/removal with schemaField #12224

Merged
merged 4 commits into from
Dec 27, 2024
Merged

feat(businessAttribute): generate platform events on association/removal with schemaField #12224

merged 4 commits into from
Dec 27, 2024

Conversation

deepgarg-visa
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 25, 2024
@deepgarg-visa deepgarg-visa changed the title feat(businessAttribute): generate platform events on association/removal of businessattributes with schemaField feat(businessAttribute): generate platform events on association/removal with schemaField Dec 25, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 25, 2024
david-leifker
david-leifker reviewed Dec 26, 2024
View reviewed changes
...va/com/linkedin/metadata/timeline/eventgenerator/BusinessAttributesChangeEventGenerator.java
@@ -0,0 +1,98 @@
package com.linkedin.metadata.timeline.eventgenerator;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class requires some test coverage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-leifker added

david-leifker
david-leifker requested changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes here look good to me. The only request is to add some unit tests around the new BusinessAttributesChangeEventGenerator class.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 26, 2024
@deepgarg-visa deepgarg-visa force-pushed the platform-events-business-attribute branch from 715d0bd to 05673f1 Compare December 26, 2024 17:15
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 27, 2024
@deepgarg-visa deepgarg-visa force-pushed the platform-events-business-attribute branch from e7139f6 to 16a9900 Compare December 27, 2024 14:38
@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Dec 27, 2024
@david-leifker david-leifker merged commit 6b6d820 into datahub-project:master Dec 27, 2024
83 of 101 checks passed
brock-acryl pushed a commit to brock-acryl/datahub that referenced this pull request Jan 30, 2025
@deepgarg-visa @chakru-r
feat(businessAttribute): generate platform events on association/remo…
2808911 
…val with schemaField (datahub-project#12224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepgarg-visa @david-leifker