Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/glue): Add additional checks and logging when specifying catalog_id #12168

Merged
merged 6 commits into from
Dec 24, 2024
Merged

fix(ingest/glue): Add additional checks and logging when specifying catalog_id #12168

merged 6 commits into from
Dec 24, 2024

Conversation

asikowitz
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 18, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 18, 2024
sgomezvillamor
sgomezvillamor approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

metadata-ingestion/src/datahub/ingestion/source/aws/glue.py Outdated
and database.get("CatalogId")
and database.get("CatalogId") != self.source_config.catalog_id
):
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this issue has occurred in the past, we might consider adding a log: skipping because of non matching catalog id

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 20, 2024
@asikowitz asikowitz merged commit 756b199 into datahub-project:master Dec 24, 2024
76 checks passed
@asikowitz asikowitz deleted the glue-database-catalog-filter branch December 24, 2024 22:56
brock-acryl pushed a commit to brock-acryl/datahub that referenced this pull request Jan 30, 2025
@asikowitz @chakru-r
fix(ingest/glue): Add additional checks and logging when specifying c…
8ad8664 
…atalog_id (datahub-project#12168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asikowitz @sgomezvillamor