Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ingest): fix sink recipe to correct config parameter #12132

Merged
merged 1 commit into from
Dec 16, 2024
Merged

docs(ingest): fix sink recipe to correct config parameter #12132

merged 1 commit into from
Dec 16, 2024

Conversation

kousiknandy
Copy link
Contributor

It's filename instead of path, it may confuse the innocent if they follow the recipe to debug or demo

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@kousiknandy
Update recipe to correct config parameter
4c201ca 
It's filename instead of path, it may confuse the innocent if they follow the recipe to debug or demo
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 13, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 13, 2024
shirshanka
shirshanka approved these changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.
This was introduced erroneously in #12101
cc @aseembansal-gogo - FileSource supports path as config, but FileSink doesn't (yet).

@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Dec 14, 2024
@hsheth2 hsheth2 changed the title Update recipe to correct config parameter docs(ingest): fix sink recipe to correct config parameter Dec 16, 2024
@hsheth2 hsheth2 merged commit ca6f435 into datahub-project:master Dec 16, 2024
95 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@kousiknandy @sleeperdeep
docs(ingest): fix sink recipe to correct config parameter (datahub-pr…
c539e31 
…oject#12132)
brock-acryl pushed a commit to brock-acryl/datahub that referenced this pull request Jan 30, 2025
@kousiknandy @chakru-r
docs(ingest): fix sink recipe to correct config parameter (datahub-pr…
54f3f84 
…oject#12132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kousiknandy @shirshanka @hsheth2