Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[ingest/build]: Disable preflight script as it is not needed anymore #11989

Merged
merged 3 commits into from
Dec 2, 2024
Merged

fix[ingest/build]: Disable preflight script as it is not needed anymore #11989

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71f1701
Preflight script seems to not needed anymore
treff7es Nov 28, 2024
de4133a
Remove preflight script
treff7es Nov 29, 2024
49280fc
Merge branch 'master' into disable_preflight_script
treff7es Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions metadata-ingestion/scripts/datahub_preflight.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/bin/bash -e

echo "Not running anymore preflight script"
exit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just delete this script entirely? We can always recover it from git history

#From https://stackoverflow.com/questions/4023830/how-to-compare-two-strings-in-dot-separated-version-format-in-bash
verlte() {
[ "$1" == "$(echo -e "$1\n$2" | sort -V | head -n1)" ]
Expand Down
Loading