Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/sigma): migrate sigma workbooks from container to dashboard #11939

Merged
merged 7 commits into from
Nov 26, 2024
Merged

fix(ingest/sigma): migrate sigma workbooks from container to dashboard #11939

merged 7 commits into from
Nov 26, 2024

Conversation

sagar-salvi-apptware
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 25, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 25, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Nov 25, 2024
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/CUS-3191-sigma-dahsboard branch from 74f5da0 to ae25414 Compare November 25, 2024 11:49
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Nov 25, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter needs-review Label for PRs that need review from a maintainer. and removed needs-review Label for PRs that need review from a maintainer. pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Nov 25, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Nov 25, 2024
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/CUS-3191-sigma-dahsboard branch from 497ccc0 to 2179198 Compare November 25, 2024 21:49
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Nov 25, 2024
@mayurinehate mayurinehate self-requested a review November 26, 2024 08:30
mayurinehate
mayurinehate approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Nov 26, 2024
@mayurinehate mayurinehate merged commit b357f87 into datahub-project:master Nov 26, 2024
106 checks passed
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Nov 26, 2024
@sagar-salvi-apptware @shirshanka
fix(ingest/sigma): migrate sigma workbooks from container to dashboard (
ba0c12a 
datahub-project#11939)
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@sagar-salvi-apptware @sleeperdeep
fix(ingest/sigma): migrate sigma workbooks from container to dashboard (
1e2a5f5 
datahub-project#11939)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagar-salvi-apptware @mayurinehate