Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): add test for lowercase #11914

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(ingest): add test for lowercase #11914

wants to merge 1 commit into from

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal marked this pull request as draft November 21, 2024 12:45
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 21, 2024
hsheth2
hsheth2 approved these changes Nov 21, 2024
View reviewed changes
metadata-ingestion/tests/unit/api/source_helpers/test_source_helpers.py
Comment on lines +119 to +120
expected = [
*list(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expected = [
*list(
expected = list(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @hsheth2