Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ingest): start using explicit exports #11899

Merged
merged 9 commits into from
Nov 20, 2024
Merged

chore(ingest): start using explicit exports #11899

merged 9 commits into from
Nov 20, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 20, 2024

Starts moving us towards datahub-project/rfcs#8

  • Still need to enable this for a few additional parts of the codebase.
  • Need to move the datahub/__init__.py contents into a _version.py file.
  • Need to replace the datahub/__init__.py with a curated list of public interfaces.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 requested a review from asikowitz November 20, 2024 01:51
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 20, 2024
@hsheth2 hsheth2 added the needs-review Label for PRs that need review from a maintainer. label Nov 20, 2024
@hsheth2 hsheth2 merged commit 7dbb3e6 into master Nov 20, 2024
102 checks passed
@hsheth2 hsheth2 deleted the public-interface branch November 20, 2024 21:33
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@hsheth2 @sleeperdeep
chore(ingest): start using explicit exports (datahub-project#11899)
e8fcbc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

@asikowitz asikowitz Awaiting requested review from asikowitz

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es