Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browseDAO): Handle null browse path from ES in BrowseDAO #11875

Merged
merged 5 commits into from
Nov 25, 2024
Merged

fix(browseDAO): Handle null browse path from ES in BrowseDAO #11875

merged 5 commits into from
Nov 25, 2024

Conversation

pinakipb2
Copy link
Contributor

@pinakipb2 pinakipb2 commented Nov 18, 2024 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Background:

In PR: https://github.com/datahub-project/datahub/pull/11514/files, empty strings were considered as null for ES indexing.

In Kibana:

image

From DB (aspect):

image

Issue:

This is causing null pointer exception for entities, where browse path is empty string.

Which is emulated in the below test:

image

Have added test for the changes as well.

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Nov 18, 2024
@pinakipb2 pinakipb2 marked this pull request as ready for review November 18, 2024 10:19
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 20, 2024
jjoyce0510
jjoyce0510 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution!

@jjoyce0510 jjoyce0510 merged commit 5da3904 into datahub-project:master Nov 25, 2024
45 checks passed
@pinakipb2 pinakipb2 deleted the pb-null-browse-path branch November 25, 2024 18:22
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@pinakipb2 @sleeperdeep
fix(browseDAO): Handle null browse path from ES in BrowseDAO (datahub…
1b0b958 
…-project#11875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinakipb2 @jjoyce0510