chore(structured-properties): add cli validation for entity types #11863
Conversation
github-actions
bot
added
ingestion
| VALID_ENTITY_TYPES_PREFIX_STRING = ", ".join( | ||
| [ | ||
| f"urn:li:entityType:datahub.{x}" | ||
| for x in ["dataset", "dashboard", "dataFlow", "schemaField"] |
There was a problem hiding this comment.
Just a temporary example?
There was a problem hiding this comment.
Does the python code have access to the entity registry or is that server side only?
There was a problem hiding this comment.
Hmm, I wonder if you might parse this http://localhost:9002/openapi/v3/api-docs/10-openapi-v3 as a workaround.
There was a problem hiding this comment.
That's the openapi spec that is generated from the entity registry on the running server as a proxy for the entity registry's data.
There was a problem hiding this comment.
the problem is that technically - one could register a new entityType completely dynamically. So generating a valid list of entityTypes by consulting the server requires talking to the data plane (not just the entity registry / openapi spec)
There was a problem hiding this comment.
This list of entities is just a sample... the error message looks like this:
Input urn:li:entityType:dataset is not a valid entity type urn. Valid entity type urns are urn:li:entityType:datahub.dataset, urn:li:entityType:datahub.dashboard, urn:li:entityType:datahub.dataFlow, urn:li:entityType:datahub.schemaField, etc... Ensure that the entity type is valid. (type=value_error)
Adds validation for entity types referenced in structured property definition yaml files.
Checklist