Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): add missing package #11842

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix(config): add missing package #11842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d9a223
fix(config): add missing package
RyanHolstien Nov 12, 2024
952e7e7
add test
RyanHolstien Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions metadata-service/war/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ dependencies {
implementation externalDependency.awsMskIamAuth
testRuntimeOnly externalDependency.logbackClassic
implementation externalDependency.charle

testImplementation externalDependency.testng
testImplementation externalDependency.springBootTest
testRuntimeOnly externalDependency.logbackClassic
}
configurations.all{
exclude group: "com.charleskorn.kaml", module:"kaml"
Expand Down
3 changes: 2 additions & 1 deletion metadata-service/war/src/main/java/com/linkedin/gms/CommonApplicationConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
"com.linkedin.gms.factory.plugins",
"com.linkedin.gms.factory.change",
"com.datahub.event.hook",
"com.linkedin.gms.factory.notifications"
"com.linkedin.gms.factory.notifications",
"com.linkedin.gms.factory.telemetry"
})
@PropertySource(value = "classpath:/application.yaml", factory = YamlPropertySourceFactory.class)
@Configuration
Expand Down
32 changes: 32 additions & 0 deletions metadata-service/war/src/test/java/com/linkedin/gms/SpringTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package com.linkedin.gms;

import static org.testng.AssertJUnit.assertNotNull;

import com.linkedin.gms.factory.telemetry.DailyReport;
import com.linkedin.metadata.models.registry.ConfigEntityRegistry;
import com.linkedin.metadata.models.registry.EntityRegistry;
import io.ebean.Database;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.boot.test.mock.mockito.MockBean;
import org.springframework.test.context.ContextConfiguration;
import org.springframework.test.context.testng.AbstractTestNGSpringContextTests;
import org.testng.annotations.Test;

@SpringBootTest(
webEnvironment = SpringBootTest.WebEnvironment.MOCK,
properties = {"telemetry.enabledServer=true"})
@ContextConfiguration(classes = CommonApplicationConfig.class)
public class SpringTest extends AbstractTestNGSpringContextTests {

// Mock Beans take precedence, we add these to avoid needing to configure data sources etc. while
// still testing prod config
@MockBean private Database database;
@MockBean private ConfigEntityRegistry configEntityRegistry;
@MockBean private EntityRegistry entityRegistry;

@Test
public void testTelemetry() {
DailyReport dailyReport = this.applicationContext.getBean(DailyReport.class);
assertNotNull(dailyReport);
}
}
Loading