Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk):platform-resource - complex queries #11675

Merged
merged 1 commit into from
Oct 19, 2024
Merged

feat(sdk):platform-resource - complex queries #11675

merged 1 commit into from
Oct 19, 2024

Conversation

shirshanka
Copy link
Contributor

  • Improves the sdk support for platform resources
  • Creates opportunities for other entities to support richer find-ability
  • [Note] Breaks previous API for platform resource.search_by_filters (this shouldn't need an entry in the updating datahub list because we haven't cut a new release with the previous api)

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata smoke_test Contains changes related to smoke tests labels Oct 19, 2024
hsheth2
hsheth2 approved these changes Oct 19, 2024
View reviewed changes
metadata-ingestion/src/datahub/api/entities/platformresource/platform_resource.py
class DataPlatformInstanceUrn:
"""
A simple implementation of a URN class for DataPlatformInstance.
Since this is not present in the URN registry, we need to implement it here.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The urn types are autogenerated- we can definitely just add this there instead of building a new type

metadata-ingestion/src/datahub/api/entities/platformresource/platform_resource.py
super().__init__()

@classmethod
def create_from(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We lose typing here :(

@shirshanka shirshanka force-pushed the sdk-platform-resource-better-filters branch from a5565cd to d6a05e8 Compare October 19, 2024 20:52
@shirshanka shirshanka merged commit 3b1b762 into datahub-project:master Oct 19, 2024
70 of 73 checks passed
aviv-julienjehannet pushed a commit to aviv-julienjehannet/datahub that referenced this pull request Oct 21, 2024
@shirshanka @aviv-julienjehannet
feat(sdk):platform-resource - complex queries (datahub-project#11675)
df74565
aviv-julienjehannet pushed a commit to aviv-julienjehannet/datahub that referenced this pull request Oct 21, 2024
@shirshanka @aviv-julienjehannet
feat(sdk):platform-resource - complex queries (datahub-project#11675)
81d9881
epatotski pushed a commit to acryldata/datahub that referenced this pull request Oct 22, 2024
@shirshanka @patotskiy
feat(sdk):platform-resource - complex queries (datahub-project#11675)
417a247
k-bartlett pushed a commit to k-bartlett/datahub that referenced this pull request Oct 23, 2024
@shirshanka @keith-fullsight
feat(sdk):platform-resource - complex queries (datahub-project#11675)
bda79bd
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@shirshanka @sleeperdeep
feat(sdk):platform-resource - complex queries (datahub-project#11675)
065f9ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirshanka @hsheth2