-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(ingest/redshift): limit copy lineage #11662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This limits it to a max of 20 entries per table, which means that we can't get overwhelmed by lineage entries for tables with ultra-high traffic.
hsheth2
changed the title
feat(ingest/redshift): limit copy lineage
perf(ingest/redshift): limit copy lineage
Oct 17, 2024
github-actions
bot
added
the
ingestion
PR or Issue related to the ingestion of metadata
label
Oct 17, 2024
mayurinehate
approved these changes
Oct 18, 2024
c.file_name AS filename, | ||
ROW_NUMBER() OVER ( | ||
PARTITION BY sti."schema", sti."table" | ||
ORDER BY si.start_time ASC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use DESC in favour of getting latest rows ?
mayurinehate
added
the
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
label
Oct 22, 2024
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Dec 17, 2024
Co-authored-by: Mayuri Nehate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ingestion
PR or Issue related to the ingestion of metadata
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limits it to a max of 20 entries per table, which means that we can't get overwhelmed by lineage entries for tables with ultra-high traffic.
Checklist