Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/delta-lake): skip file count if require_files is false #11611

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Oct 14, 2024

File count returned 0 earlier for this case. This is raising exception for deltalake>=0.20.0 (Ref: delta-io/delta-rs@ad35eda#diff-f81b8b91e9721dc0a3235b6674a57c0700153b92b59f3988d357950a9c8c4760)

  • Also fixes mlflow lint error from CI

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 14, 2024
@mayurinehate mayurinehate merged commit b74ba11 into datahub-project:master Oct 14, 2024
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants