Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk(platform-resource): add entity type for ease of use #11541

Merged
merged 4 commits into from
Oct 8, 2024
Merged

sdk(platform-resource): add entity type for ease of use #11541

merged 4 commits into from
Oct 8, 2024

Conversation

shirshanka
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata smoke_test Contains changes related to smoke tests labels Oct 6, 2024
@shirshanka shirshanka force-pushed the sdk--platform-resource branch from b53276e to fe78e5f Compare October 7, 2024 05:51
hsheth2
hsheth2 reviewed Oct 7, 2024
View reviewed changes
metadata-ingestion/src/datahub/api/entities/common/serialized_value.py Outdated
Comment on lines 48 to 51
# make mypy happy
model_type = eval(self.schema_ref)
assert issubclass(model_type, BaseModel)
return model_type(**object_dict)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems pretty scary

metadata-ingestion/src/datahub/api/entities/platformresource/platform_resource.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/api/entities/common/serialized_value.py Outdated

class TypedResourceValue(BaseModel):

object: Optional[Union[Dict, DictWrapper, BaseModel]] = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when does None make sense here? imo it shouldn't be optional

metadata-ingestion/src/datahub/api/entities/platformresource/platform_resource.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/api/entities/platformresource/platform_resource.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/api/entities/platformresource/platform_resource.py Outdated Show resolved Hide resolved
@shirshanka shirshanka marked this pull request as ready for review October 8, 2024 01:15
@shirshanka shirshanka merged commit f3a348a into datahub-project:master Oct 8, 2024
69 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@shirshanka @sleeperdeep
sdk(platform-resource): add entity type for ease of use (datahub-proj…
e8e99ef 
…ect#11541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirshanka @hsheth2