-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest): include platform instance in looker usage urns #11469
Conversation
Follow up on #10771 That PR updated most looker urns to use the platform instance when configured, but missed updating the usage code. This finishes the job.
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@hsheth2 linter fails on pr |
Follow up on #10771
That PR updated most looker urns to use the platform instance when configured, but missed updating the usage code. This finishes the job by passing the urn builder function in as a parameter, so the urn construction logic only lives in one place.
It also refactors the Looker usage code to remove
cast
calls and overall be more readable.Checklist