-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(structuredProps) Allow upserting structured props on schema fields that don't exist #11466
fix(structuredProps) Allow upserting structured props on schema fields that don't exist #11466
Conversation
…s that don't exist yet
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. We could add a TODO to remove this once the schema field side effect is in production, but honestly not sure if that's needed... seems like a safe change to have in general
Most schema fields don't have their own urns yet in the database and structured properties are the first main aspect we're storing on them. This PR edits the
upsertStructuredProperties
endpoint to allow users to add a property to a schema field urn that doesn't exist yet. This way users will be able to add/remove properties on schema fields even if they weren't minted by some other way yet (other than forms or API, there is no other way as far as I know).Checklist