-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest/looker) : Handle DeserializeError to improve error reporting. #11457
fix(ingest/looker) : Handle DeserializeError to improve error reporting. #11457
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
461f635
to
9d3adbf
Compare
9d3adbf
to
a9921c6
Compare
@sagar-salvi-apptware can we merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs some tweaks to the error reporting
metadata-ingestion/src/datahub/ingestion/source/looker/looker_common.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/looker/looker_common.py
Outdated
Show resolved
Hide resolved
Yes we can, I ll fix the comment then we can merge |
…ng, underlying issue remains
59d8bdc
to
04688c6
Compare
04688c6
to
1fe2c9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there on this one
We're actively working on improving our error reporting across the codebase, so new error reporting code is held to a much higher standard than it was before
metadata-ingestion/src/datahub/ingestion/source/looker/looker_common.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/looker/looker_common.py
Outdated
Show resolved
Hide resolved
1fe2c9a
to
8077db3
Compare
8077db3
to
4e8a707
Compare
metadata-ingestion/src/datahub/ingestion/source/looker/looker_source.py
Outdated
Show resolved
Hide resolved
…ng. (datahub-project#11457) Co-authored-by: Harshal Sheth <[email protected]>
Checklist