-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/dbt): produce multiple assertions for multi-table dbt tests #11451
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Stacked on #11450
For dbt tests that depend on multiple underlying models (e.g. relationship tests), we previously would only produce one datahub assertion. The dataset that this assertion was associated with was not consistently defined (it used to be whatever model was last when alphabetically ordered - not sure why). This changes it so we produce multiple dataset assertions for the dbt test, one per dataset. While it's not strictly correct, the end user experience will make more sense. The assertions produced will have custom properties in case they need to be linked in the future.
Checklist