Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest/sink): report datahub-rest sink mode #11422

Merged
merged 2 commits into from
Sep 20, 2024
Merged

feat(ingest/sink): report datahub-rest sink mode #11422

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
babe5c0
feat(ingest/sink): report datahub-rest sink mode
hsheth2 Sep 18, 2024
bfd77ba
Merge branch 'master' into report-sink-mode
hsheth2 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions metadata-ingestion/src/datahub/ingestion/sink/datahub_rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ class DatahubRestSinkConfig(DatahubClientConfig):

@dataclasses.dataclass
class DataHubRestSinkReport(SinkReport):
mode: Optional[RestSinkMode] = None
max_threads: Optional[int] = None
gms_version: Optional[str] = None
pending_requests: int = 0
Expand Down Expand Up @@ -126,6 +127,7 @@ def __post_init__(self) -> None:
.get("acryldata/datahub", {})
.get("version", None)
)
self.report.mode = self.config.mode
self.report.max_threads = self.config.max_threads
logger.debug("Setting env variables to override config")
logger.debug("Setting gms config")
Expand Down
Loading