feat(ingest/sql): auto extract and use mode query user metadata #11307

mayurinehate · 2024-09-05T10:37:19Z

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

coderabbitai · 2024-09-05T10:37:26Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

mayurinehate · 2024-09-05T10:43:08Z

@coderabbitai review

coderabbitai · 2024-09-05T10:43:13Z

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

hsheth2

bit of confusion about extra_info and where it's used, but overall looks pretty reasonable

hsheth2 · 2024-09-05T21:01:54Z

metadata-ingestion/src/datahub/sql_parsing/tool_meta_extractor.py

+    """
+
+    query_text: str
+    user: Optional[Union[CorpUserUrn, CorpGroupUrn]]


is the idea that both preparsed queries and observed queries will match this interface?

Yes, ultimately, that's the goal . Anything that has "query", "user" and "extra_info" can use this.
ObservedQuery and PreparsedQuery share these concepts but not named/typed similarly. Refactoring can be done to achieve this, however currently not done as add_observed_query path ultimately invokes add_preparsed_query path. So it suffices for only PreparsedQuery to follow this protocol.

hsheth2 · 2024-09-05T21:06:24Z

metadata-ingestion/src/datahub/sql_parsing/sql_parsing_aggregator.py

@@ -736,6 +749,9 @@ def add_preparsed_query(
        session_has_temp_tables: bool = True,
        _is_internal: bool = False,
    ) -> None:
+
+        self._tool_meta_extractor.extract_bi_metadata(parsed)


this is a bit tricky - we only need it here, since observed query calls this?

imo it's a bit confusing because ObservedQuery also has extra_info, but that isn't copied over by add() or add_observed_query

Right.

How about removing extra_info entirely. I do not believe we are doing anything with user_via just yet.

Also I believe we could place the line self._tool_meta_extractor.extract_bi_metadata(parsed) in add() right before invoking add_preparsed_query or add_observed_query instead of here and also refractor PreparsedQuery / ObservedQuery to support base protocol - renaming of query_text to query, etc. What do you think? Would it be less confusing then ?

Added some refactoring + comment + passing extra_info to PreParsedQuery.

metadata-ingestion/tests/integration/bigquery_v2/test_bigquery_queries.py

metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/queries_extractor.py

feat(sqlparsing): auto extract and use mode query user metadata

c684985

github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 5, 2024

fix import

8377c91

mayurinehate requested a review from hsheth2 September 5, 2024 10:46

vercel bot deployed to Preview September 5, 2024 11:10 View deployment

fix import

6762018

vercel bot deployed to Preview September 5, 2024 11:41 View deployment

hsheth2 reviewed Sep 5, 2024

View reviewed changes

mayurinehate and others added 3 commits September 6, 2024 11:35

refactor add_observed_query, pass extra_info to preparsed query

8a795d4

add comment for clarity

d75914c

Merge branch 'master' into feature/ing-705

75bdd7f

vercel bot deployed to Preview September 6, 2024 06:38 View deployment

hsheth2 reviewed Sep 6, 2024

View reviewed changes

metadata-ingestion/tests/integration/bigquery_v2/test_bigquery_queries.py Outdated Show resolved Hide resolved

hsheth2 approved these changes Sep 6, 2024

View reviewed changes

metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/queries_extractor.py Outdated Show resolved Hide resolved

hsheth2 added 2 commits September 6, 2024 10:43

Merge branch 'master' into feature/ing-705

126de6f

Apply suggestions from code review

1043950

hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Sep 6, 2024

vercel bot deployed to Preview September 6, 2024 18:17 View deployment

fix test

9949ef0

vercel bot deployed to Preview September 9, 2024 07:51 View deployment

hsheth2 changed the title ~~feat(sqlparsing): auto extract and use mode query user metadata~~ feat(ingest/sql): auto extract and use mode query user metadata Sep 9, 2024

hsheth2 merged commit cf49f80 into datahub-project:master Sep 9, 2024
67 of 68 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ingest/sql): auto extract and use mode query user metadata #11307

feat(ingest/sql): auto extract and use mode query user metadata #11307

mayurinehate commented Sep 5, 2024

coderabbitai bot commented Sep 5, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

mayurinehate commented Sep 5, 2024

coderabbitai bot commented Sep 5, 2024

hsheth2 left a comment

hsheth2 Sep 5, 2024

mayurinehate Sep 6, 2024 •

edited

Loading

hsheth2 Sep 5, 2024

mayurinehate Sep 6, 2024

mayurinehate Sep 6, 2024

feat(ingest/sql): auto extract and use mode query user metadata #11307

feat(ingest/sql): auto extract and use mode query user metadata #11307

Conversation

mayurinehate commented Sep 5, 2024

Checklist

coderabbitai bot commented Sep 5, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

mayurinehate commented Sep 5, 2024

coderabbitai bot commented Sep 5, 2024

hsheth2 left a comment

Choose a reason for hiding this comment

hsheth2 Sep 5, 2024

Choose a reason for hiding this comment

mayurinehate Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

hsheth2 Sep 5, 2024

Choose a reason for hiding this comment

mayurinehate Sep 6, 2024

Choose a reason for hiding this comment

mayurinehate Sep 6, 2024

Choose a reason for hiding this comment

coderabbitai bot commented Sep 5, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

mayurinehate Sep 6, 2024 •

edited

Loading