Advance search - Added case sensitive flag for wildcard searches #11272

kanavnarula · 2024-08-30T08:04:01Z

Current global text search on browse page brings case insensitive results. With advance filters added, search becomes case sensitive.

Adding caseInsensitive param to help get all results with wildcard searches.

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

coderabbitai · 2024-08-30T08:04:07Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai generate interesting stats about this repository and render them as a table.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

jayasimhankv · 2024-08-30T12:30:27Z

metadata-io/src/main/java/com/linkedin/metadata/search/utils/ESUtils.java

@@ -558,7 +558,8 @@ private static QueryBuilder getQueryBuilderFromCriterionForSingleField(
        return QueryBuilders.wildcardQuery(
                toKeywordField(criterion.getField(), isTimeseries, aspectRetriever),
                "*" + ESUtils.escapeReservedCharacters(criterion.getValue().trim()) + "*")
-            .queryName(queryName != null ? queryName : fieldName);
+            .queryName(queryName != null ? queryName : fieldName)
+            .caseInsensitive(true);


👍 This will be a good addition for searches!

david-leifker

lgtm!

david-leifker · 2024-09-10T17:06:54Z

> The following files had format violations:
      src/main/java/com/linkedin/metadata/search/utils/ESUtils.java
          @@ -582,7 +582,8 @@
           ··········QueryBuilders.wildcardQuery(
           ··················toKeywordField(criterion.getField(),·isTimeseries,·aspectRetriever),
           ··················String.format(wildcardPattern,·ESUtils.escapeReservedCharacters(value.trim())))
          -··············.queryName(queryName·!=·null·?·queryName·:·fieldName).caseInsensitive(true));
          +··············.queryName(queryName·!=·null·?·queryName·:·fieldName)
          +··············.caseInsensitive(true));
           ····}
           ····return·boolQuery;
           ··}
  Run './gradlew :metadata-io:spotlessApply' to fix these violations.

ptal @kanavnarula

kanavnarula · 2024-09-14T15:15:27Z

> The following files had format violations:
      src/main/java/com/linkedin/metadata/search/utils/ESUtils.java
          @@ -582,7 +582,8 @@
           ··········QueryBuilders.wildcardQuery(
           ··················toKeywordField(criterion.getField(),·isTimeseries,·aspectRetriever),
           ··················String.format(wildcardPattern,·ESUtils.escapeReservedCharacters(value.trim())))
          -··············.queryName(queryName·!=·null·?·queryName·:·fieldName).caseInsensitive(true));
          +··············.queryName(queryName·!=·null·?·queryName·:·fieldName)
          +··············.caseInsensitive(true));
           ····}
           ····return·boolQuery;
           ··}
  Run './gradlew :metadata-io:spotlessApply' to fix these violations.

ptal @kanavnarula

This is taken care @david-leifker . Please take a look once again. Thanks!

david-leifker · 2024-09-17T13:05:40Z

Getting close now, 3 failed tests in metadata-io

metadata-io > nonsearch > com.linkedin.metadata.search.utils.ESUtilsTest > testGetQueryBuilderFromCriterionContain FAILED
    java.lang.AssertionError: expected [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "*value1*",
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }] but found [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "*value1*",
          "case_insensitive" : true,
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }]
        at org.testng.Assert.fail(Assert.java:111)
        at org.testng.Assert.failNotEquals(Assert.java:1578)
        at org.testng.Assert.assertEqualsImpl(Assert.java:150)
        at org.testng.Assert.assertEquals(Assert.java:132)
        at org.testng.Assert.assertEquals(Assert.java:656)
        at org.testng.Assert.assertEquals(Assert.java:666)
        at com.linkedin.metadata.search.utils.ESUtilsTest.testGetQueryBuilderFromCriterionContain(ESUtilsTest.java:186)

metadata-io > nonsearch > com.linkedin.metadata.search.utils.ESUtilsTest > testWildcardQueryBuilderFromCriterionWhenEndsWith FAILED
    java.lang.AssertionError: expected [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "*value1",
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }] but found [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "*value1",
          "case_insensitive" : true,
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }]
        at org.testng.Assert.fail(Assert.java:111)
        at org.testng.Assert.failNotEquals(Assert.java:1578)
        at org.testng.Assert.assertEqualsImpl(Assert.java:150)
        at org.testng.Assert.assertEquals(Assert.java:132)
        at org.testng.Assert.assertEquals(Assert.java:656)
        at org.testng.Assert.assertEquals(Assert.java:666)
        at com.linkedin.metadata.search.utils.ESUtilsTest.testWildcardQueryBuilderFromCriterionWhenEndsWith(ESUtilsTest.java:330)

metadata-io > nonsearch > com.linkedin.metadata.search.utils.ESUtilsTest > testWildcardQueryBuilderFromCriterionWhenStartsWith FAILED
    java.lang.AssertionError: expected [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "value1*",
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }] but found [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "value1*",
          "case_insensitive" : true,
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }]
        at org.testng.Assert.fail(Assert.java:111)
        at org.testng.Assert.failNotEquals(Assert.java:1578)
        at org.testng.Assert.assertEqualsImpl(Assert.java:150)
        at org.testng.Assert.assertEquals(Assert.java:132)
        at org.testng.Assert.assertEquals(Assert.java:656)
        at org.testng.Assert.assertEquals(Assert.java:666)
        at com.linkedin.metadata.search.utils.ESUtilsTest.testWildcardQueryBuilderFromCriterionWhenStartsWith(ESUtilsTest.java:260)

kanavnarula · 2024-09-17T15:57:47Z

Getting close now, 3 failed tests in metadata-io

metadata-io > nonsearch > com.linkedin.metadata.search.utils.ESUtilsTest > testGetQueryBuilderFromCriterionContain FAILED
    java.lang.AssertionError: expected [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "*value1*",
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }] but found [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "*value1*",
          "case_insensitive" : true,
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }]
        at org.testng.Assert.fail(Assert.java:111)
        at org.testng.Assert.failNotEquals(Assert.java:1578)
        at org.testng.Assert.assertEqualsImpl(Assert.java:150)
        at org.testng.Assert.assertEquals(Assert.java:132)
        at org.testng.Assert.assertEquals(Assert.java:656)
        at org.testng.Assert.assertEquals(Assert.java:666)
        at com.linkedin.metadata.search.utils.ESUtilsTest.testGetQueryBuilderFromCriterionContain(ESUtilsTest.java:186)

metadata-io > nonsearch > com.linkedin.metadata.search.utils.ESUtilsTest > testWildcardQueryBuilderFromCriterionWhenEndsWith FAILED
    java.lang.AssertionError: expected [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "*value1",
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }] but found [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "*value1",
          "case_insensitive" : true,
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }]
        at org.testng.Assert.fail(Assert.java:111)
        at org.testng.Assert.failNotEquals(Assert.java:1578)
        at org.testng.Assert.assertEqualsImpl(Assert.java:150)
        at org.testng.Assert.assertEquals(Assert.java:132)
        at org.testng.Assert.assertEquals(Assert.java:656)
        at org.testng.Assert.assertEquals(Assert.java:666)
        at com.linkedin.metadata.search.utils.ESUtilsTest.testWildcardQueryBuilderFromCriterionWhenEndsWith(ESUtilsTest.java:330)

metadata-io > nonsearch > com.linkedin.metadata.search.utils.ESUtilsTest > testWildcardQueryBuilderFromCriterionWhenStartsWith FAILED
    java.lang.AssertionError: expected [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "value1*",
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }] but found [{
      "wildcard" : {
        "myTestField.keyword" : {
          "wildcard" : "value1*",
          "case_insensitive" : true,
          "boost" : 1.0,
          "_name" : "myTestField"
        }
      }
    }]
        at org.testng.Assert.fail(Assert.java:111)
        at org.testng.Assert.failNotEquals(Assert.java:1578)
        at org.testng.Assert.assertEqualsImpl(Assert.java:150)
        at org.testng.Assert.assertEquals(Assert.java:132)
        at org.testng.Assert.assertEquals(Assert.java:656)
        at org.testng.Assert.assertEquals(Assert.java:666)
        at com.linkedin.metadata.search.utils.ESUtilsTest.testWildcardQueryBuilderFromCriterionWhenStartsWith(ESUtilsTest.java:260)

Thanks for sharing @david-leifker ! Updated the test cases and committed. Please take a look when you get time

david-leifker · 2024-09-18T15:54:20Z

LGTM! Thank you!

kanavnarula · 2024-09-19T04:25:33Z

Thanks @david-leifker!

…ahub-project#11272) Co-authored-by: mac <[email protected]> Co-authored-by: david-leifker <[email protected]> Co-authored-by: Kanav Narula <[email protected]>

Advance search - Added case sensitive flag for CONTAINS

8457b94

github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Aug 30, 2024

vercel bot deployed to Preview August 30, 2024 08:21 View deployment

Merge branch 'master' into master

fe84c68

vercel bot deployed to Preview August 30, 2024 11:54 View deployment

jayasimhankv reviewed Aug 30, 2024

View reviewed changes

david-leifker approved these changes Sep 5, 2024

View reviewed changes

Merge branch 'master' into master

7d91099

vercel bot deployed to Preview September 10, 2024 15:45 View deployment

mac and others added 2 commits September 14, 2024 20:39

Spotless fix

c600aa5

Merge branch 'master' into master

34a8348

vercel bot deployed to Preview September 14, 2024 15:45 View deployment

Merge branch 'master' into master

8181eb8

vercel bot deployed to Preview September 17, 2024 04:48 View deployment

Merge branch 'master' into master

59674e8

david-leifker self-assigned this Sep 17, 2024

vercel bot deployed to Preview September 17, 2024 13:07 View deployment

Kanav Narula and others added 2 commits September 17, 2024 21:13

test cases

86caccc

Merge branch 'master' into master

253b54b

vercel bot deployed to Preview September 17, 2024 16:31 View deployment

Merge branch 'master' into master

21e47b2

vercel bot deployed to Preview September 17, 2024 17:41 View deployment

Merge branch 'master' into master

78678a5

vercel bot deployed to Preview September 17, 2024 21:53 View deployment

Merge branch 'master' into master

77a0372

vercel bot deployed to Preview September 18, 2024 05:42 View deployment

Merge branch 'master' into master

5cf0d60

vercel bot deployed to Preview September 18, 2024 10:34 View deployment

david-leifker merged commit 4693ab0 into datahub-project:master Sep 18, 2024
41 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Advance search - Added case sensitive flag for wildcard searches #11272

Advance search - Added case sensitive flag for wildcard searches #11272

kanavnarula commented Aug 30, 2024

coderabbitai bot commented Aug 30, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

jayasimhankv Aug 30, 2024

david-leifker left a comment

david-leifker commented Sep 10, 2024

kanavnarula commented Sep 14, 2024

david-leifker commented Sep 17, 2024

kanavnarula commented Sep 17, 2024

david-leifker commented Sep 18, 2024

kanavnarula commented Sep 19, 2024

Advance search - Added case sensitive flag for wildcard searches #11272

Advance search - Added case sensitive flag for wildcard searches #11272

Conversation

kanavnarula commented Aug 30, 2024

Checklist

coderabbitai bot commented Aug 30, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

jayasimhankv Aug 30, 2024

Choose a reason for hiding this comment

david-leifker left a comment

Choose a reason for hiding this comment

david-leifker commented Sep 10, 2024

kanavnarula commented Sep 14, 2024

david-leifker commented Sep 17, 2024

kanavnarula commented Sep 17, 2024

david-leifker commented Sep 18, 2024

kanavnarula commented Sep 19, 2024

coderabbitai bot commented Aug 30, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)