fix(ingest/snowflake): exclude snowflake excluded tags

[alisa-aylward-toast]

Snowflake tags weren't excluding properly when allow/deny was used in the pipeline. Changed the code to properly exclude them + adding tests

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

• New Features

  • Enhanced tag filtering logic in Snowflake ingestion to ensure only valid tags are retained.

• Tests

  • Introduced integration tests for Snowflake tag ingestion, validating both allowed and denied tag patterns.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the SnowflakeTagExtractor class in snowflake_tag.py, specifically refining the _filter_tags method to improve tag filtering logic. Additionally, it adds a new test file, test_snowflake_tag.py, which implements integration tests for the Snowflake ingestion feature in the DataHub framework, validating both allowed and denied tag patterns through mock configurations.

Changes

File Path	Change Summary
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_tag.py	Adjusted _filter_tags method in SnowflakeTagExtractor to append tags only if allowed by tag_pattern.
metadata-ingestion/tests/integration/snowflake/test_snowflake_tag.py	Introduced integration tests with functions test_snowflake_tag_pattern and test_snowflake_tag_pattern_deny.

Poem

🐇 In the land of Snowflake, tags dance and play,
Filtering wisely, they find their way.
With tests now in place, both allow and deny,
Our tags are safe, oh me, oh my!
Hopping through code, with joy we sing,
For clarity and order, let the changes ring! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[hsheth2]

One minor comment, otherwise looks good

[maggiehays]

@coderabbitai summary