Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafana): Using v2 metrics update datahub dashboard #11208

Merged

Conversation

AaronYang0628
Copy link
Contributor

@AaronYang0628 AaronYang0628 commented Aug 20, 2024

Fix all broken pannel in grafana, some cannot retrieve data becasue of outdated metrics name.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

  • New Features

    • Updated Grafana dashboard with a new title "Delete Latency" and extended time range to the last 12 hours.
    • Enhanced visual customization options for panels with new fields added.
    • Improved data queries by transitioning to updated data sources.
  • Bug Fixes

    • Resolved inconsistencies in metric expressions across various panels.

Copy link
Contributor

coderabbitai bot commented Aug 20, 2024

Walkthrough

The changes involve a comprehensive update to the datahub_dashboard.json file for a Grafana dashboard. Key modifications include changing the dashboard ID and schema version, extending the time range from 30 minutes to 12 hours, and updating various metrics expressions to reflect new data sources. The dashboard title has been changed, and several panels have been enhanced with new configuration fields. Overall, these updates align the dashboard with current data requirements and improve its visual representation.

Changes

File Path Change Summary
docker/monitoring/grafana/dashboards/datahub_dashboard.json - Dashboard ID changed from 95 to 56.
- Schema version updated from 37 to 39.
- Time range extended from last 30 minutes to last 12 hours.
- Metrics expressions updated from EntityResource to EntityV2Resource.
- New fields added: axisBorderShow, insertNulls, editorMode.
- Dashboard title changed from "Notification Generator latency" to "Delete Latency".
- Various panel targets modified or removed.

Poem

🐇 In the land of data, bright and new,
A dashboard's magic, we bid adieu.
From thirty minutes to twelve hours wide,
With fresh expressions, our metrics abide.
A title transformed, a bunny's delight,
Hopping through insights, oh what a sight! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Aug 20, 2024
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@david-leifker david-leifker enabled auto-merge (squash) September 10, 2024 22:16
@david-leifker david-leifker merged commit 2c34eea into datahub-project:master Sep 10, 2024
34 of 35 checks passed
@maggiehays
Copy link
Collaborator

@coderabbitai summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants