feat(actions): updates to gha workflows #11150

david-leifker · 2024-08-12T16:55:59Z

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

coderabbitai · 2024-08-12T16:56:04Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

actionlint

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:11:51: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 84 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:45: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 95 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:45: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 106 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:118: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 547 in 1f70ba2

    
           run: echo "tag=${{ needs.setup.outputs.ingestion_base_change == 'true' && needs.setup.outputs.unique_tag || 'head' }}" >> $GITHUB_OUTPUT

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:128: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 588 in 1f70ba2

    
           run: echo "tag=${{ needs.setup.outputs.ingestion_base_change == 'true' && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> $GITHUB_OUTPUT

[actionlint] _{reported by reviewdog 🐶}
missing input "image_tag" which is required by action "Custom Docker build and push" defined at "./.github/actions/docker-custom-build-and-push". all required inputs are "image_tag", "images" [action]

datahub/.github/workflows/docker-unified.yml

Line 612 in 1f70ba2

uses: ./.github/actions/docker-custom-build-and-push

[actionlint] _{reported by reviewdog 🐶}
input "tags" is not defined in action "Custom Docker build and push" defined at "./.github/actions/docker-custom-build-and-push". available inputs are "build-args", "context", "file", "flavor", "image_tag", "images", "password", "platforms", "publish", "target", "username" [action]

datahub/.github/workflows/docker-unified.yml

Line 617 in 1f70ba2

tags: ${{ needs.setup.outputs.full_tag }}

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:123: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 629 in 1f70ba2

    
           run: echo "tag=${{ needs.setup.outputs.ingestion_base_change == 'true' && needs.setup.outputs.unique_full_tag || 'head' }}" >> $GITHUB_OUTPUT

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:123: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 683 in 1f70ba2

    
           run: echo "tag=${{ needs.setup.outputs.ingestion_change == 'true' && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> $GITHUB_OUTPUT

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:113: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 769 in 1f70ba2

    
           run: echo "tag=${{ needs.setup.outputs.ingestion_change == 'true' && needs.setup.outputs.unique_tag || 'head' }}" >> $GITHUB_OUTPUT

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 811 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:4:63: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 811 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:6:95: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 811 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:8:24: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 811 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
property "short_sha" is not defined in object type {backend_change: string; backend_only: string; branch_name: string; docker-login: string; elasticsearch_setup_change: string; frontend_change: string; frontend_only: string; full_tag: string; ingestion_base_change: string; ingestion_change: string; ingestion_only: string; kafka_setup_change: string; mysql_setup_change: string; postgres_setup_change: string; pr-publish: string; publish: string; python_release_version: string; repository_name: string; slim_tag: string; tag: string; unique_full_tag: string; unique_slim_tag: string; unique_tag: string} [expression]

datahub/.github/workflows/docker-unified.yml

Line 1061 in 1f70ba2

    
           message: '{ "command": "git-sync", "args" : {"repoName": "${{ needs.setup.outputs.repository_name }}", "repoOrg": "${{ github.repository_owner }}", "repoBranch": "${{ needs.setup.outputs.branch_name }}", "repoShaShort": "${{ needs.setup.outputs.short_sha }}" }}'

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:51: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/metadata-model.yml

Line 25 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:48: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 29 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2001:style:2:7: See if you can use ${variable//search/replace} instead [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 42 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:12: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 42 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:3:20: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 42 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 78 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 91 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 104 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 117 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 130 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 143 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 156 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 169 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 182 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 195 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
property "test_strategy" is not defined in object type {} [expression]

datahub/.github/workflows/spark-smoke-test.yml

Line 66 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2162:info:5:91: read without -r will mangle backslashes [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2162:info:7:13: read without -r will mangle backslashes [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in 1f70ba2

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:8:10: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in 1f70ba2

run: |

github-actions · 2024-08-12T16:56:23Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2129:style:2:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 1f70ba2

run: |

github-actions · 2024-08-12T16:56:24Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:34: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 1f70ba2

run: |

github-actions · 2024-08-12T16:56:25Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:3:26: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 1f70ba2

run: |

github-actions · 2024-08-12T16:56:26Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:4:36: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 1f70ba2

run: |

github-actions · 2024-08-12T16:56:27Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:5:36: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 1f70ba2

run: |

github-actions · 2024-08-12T16:56:27Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:6:40: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 1f70ba2

run: |

github-actions · 2024-08-12T16:56:28Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:7:50: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 1f70ba2

run: |

github-actions · 2024-08-12T16:56:29Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:8:50: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 1f70ba2

run: |

github-actions · 2024-08-12T16:56:30Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:9:65: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 1f70ba2

run: |

github-actions · 2024-08-12T16:56:31Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:10:69: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 1f70ba2

run: |

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

actionlint

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:113: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 769 in 50e7545

    
           run: echo "tag=${{ needs.setup.outputs.ingestion_change == 'true' && needs.setup.outputs.unique_tag || 'head' }}" >> $GITHUB_OUTPUT

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 811 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:4:63: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 811 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:6:95: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 811 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:8:24: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 811 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
property "short_sha" is not defined in object type {backend_change: string; backend_only: string; branch_name: string; docker-login: string; elasticsearch_setup_change: string; frontend_change: string; frontend_only: string; full_tag: string; ingestion_base_change: string; ingestion_change: string; ingestion_only: string; kafka_setup_change: string; mysql_setup_change: string; postgres_setup_change: string; pr-publish: string; publish: string; python_release_version: string; repository_name: string; slim_tag: string; tag: string; unique_full_tag: string; unique_slim_tag: string; unique_tag: string} [expression]

datahub/.github/workflows/docker-unified.yml

Line 1061 in 50e7545

    
           message: '{ "command": "git-sync", "args" : {"repoName": "${{ needs.setup.outputs.repository_name }}", "repoOrg": "${{ github.repository_owner }}", "repoBranch": "${{ needs.setup.outputs.branch_name }}", "repoShaShort": "${{ needs.setup.outputs.short_sha }}" }}'

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:51: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/metadata-model.yml

Line 25 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:48: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 29 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2001:style:2:7: See if you can use ${variable//search/replace} instead [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 42 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:12: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 42 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:3:20: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 42 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 78 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 91 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 104 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 117 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 130 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 143 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 156 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 169 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 182 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 195 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
property "test_strategy" is not defined in object type {} [expression]

datahub/.github/workflows/spark-smoke-test.yml

Line 66 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2162:info:5:91: read without -r will mangle backslashes [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2162:info:7:13: read without -r will mangle backslashes [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in 50e7545

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:8:10: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in 50e7545

run: |

github-actions · 2024-08-13T21:02:24Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:11:51: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 68 in 50e7545

run: |

github-actions · 2024-08-13T21:02:25Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 84 in 50e7545

run: |

github-actions · 2024-08-13T21:02:26Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:45: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 95 in 50e7545

run: |

github-actions · 2024-08-13T21:02:26Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:45: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 106 in 50e7545

run: |

github-actions · 2024-08-13T21:02:27Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:118: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 547 in 50e7545

run: echo "tag=${{ needs.setup.outputs.ingestion_base_change == 'true' && needs.setup.outputs.unique_tag || 'head' }}" >> $GITHUB_OUTPUT

github-actions · 2024-08-13T21:02:28Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:128: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 588 in 50e7545

run: echo "tag=${{ needs.setup.outputs.ingestion_base_change == 'true' && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> $GITHUB_OUTPUT

github-actions · 2024-08-13T21:02:29Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
missing input "image_tag" which is required by action "Custom Docker build and push" defined at "./.github/actions/docker-custom-build-and-push". all required inputs are "image_tag", "images" [action]

datahub/.github/workflows/docker-unified.yml

Line 612 in 50e7545

uses: ./.github/actions/docker-custom-build-and-push

github-actions · 2024-08-13T21:02:29Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
input "tags" is not defined in action "Custom Docker build and push" defined at "./.github/actions/docker-custom-build-and-push". available inputs are "build-args", "context", "file", "flavor", "image_tag", "images", "password", "platforms", "publish", "target", "username" [action]

datahub/.github/workflows/docker-unified.yml

Line 617 in 50e7545

tags: ${{ needs.setup.outputs.full_tag }}

github-actions · 2024-08-13T21:02:30Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:123: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 629 in 50e7545

run: echo "tag=${{ needs.setup.outputs.ingestion_base_change == 'true' && needs.setup.outputs.unique_full_tag || 'head' }}" >> $GITHUB_OUTPUT

github-actions · 2024-08-13T21:02:31Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:123: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 683 in 50e7545

run: echo "tag=${{ needs.setup.outputs.ingestion_change == 'true' && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> $GITHUB_OUTPUT

github-actions · 2024-08-13T21:51:27Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:48: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 29 in 2bbe5c2

run: |

github-actions · 2024-08-13T21:51:28Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2001:style:2:7: See if you can use ${variable//search/replace} instead [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 42 in 2bbe5c2

run: |

github-actions · 2024-08-13T21:51:29Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:12: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 42 in 2bbe5c2

run: |

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

actionlint

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 195 in 31f42b9

run: |

[actionlint] _{reported by reviewdog 🐶}
property "test_strategy" is not defined in object type {} [expression]

datahub/.github/workflows/spark-smoke-test.yml

Line 66 in 31f42b9

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2162:info:5:91: read without -r will mangle backslashes [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in 31f42b9

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2162:info:7:13: read without -r will mangle backslashes [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in 31f42b9

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:8:10: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in 31f42b9

run: |

github-actions · 2024-08-13T22:08:13Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:3:20: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 42 in 31f42b9

run: |

github-actions · 2024-08-13T22:08:14Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 78 in 31f42b9

run: |

github-actions · 2024-08-13T22:08:15Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 91 in 31f42b9

run: |

github-actions · 2024-08-13T22:08:15Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 104 in 31f42b9

run: |

github-actions · 2024-08-13T22:08:16Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 117 in 31f42b9

run: |

github-actions · 2024-08-13T22:08:17Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 130 in 31f42b9

run: |

github-actions · 2024-08-13T22:08:18Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 143 in 31f42b9

run: |

github-actions · 2024-08-13T22:08:19Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 156 in 31f42b9

run: |

github-actions · 2024-08-13T22:08:20Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 169 in 31f42b9

run: |

github-actions · 2024-08-13T22:08:20Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 182 in 31f42b9

run: |

github-actions · 2024-08-13T22:19:47Z

.github/workflows/publish-datahub-jars.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/publish-datahub-jars.yml

Line 195 in acfc361

run: |

github-actions · 2024-08-13T22:19:48Z

.github/workflows/spark-smoke-test.yml

[actionlint] _{reported by reviewdog 🐶}
property "test_strategy" is not defined in object type {} [expression]

datahub/.github/workflows/spark-smoke-test.yml

Line 66 in acfc361

run: |

github-actions · 2024-08-13T22:19:49Z

.github/workflows/test-results.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2162:info:5:91: read without -r will mangle backslashes [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in acfc361

run: |

github-actions · 2024-08-13T22:19:50Z

.github/workflows/test-results.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2162:info:7:13: read without -r will mangle backslashes [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in acfc361

run: |

github-actions · 2024-08-13T22:19:50Z

.github/workflows/test-results.yml

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:8:10: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/test-results.yml

Line 24 in acfc361

run: |

david-leifker added the publish-docker label Aug 12, 2024

github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Aug 12, 2024

github-actions bot reviewed Aug 12, 2024

View reviewed changes

vercel bot had a problem deploying to Preview August 12, 2024 17:04 Failure

RyanHolstien approved these changes Aug 12, 2024

View reviewed changes

david-leifker enabled auto-merge (squash) August 12, 2024 20:02

feat(actions): updates to gha workflows

50e7545

david-leifker force-pushed the github-actions-1 branch from 1f70ba2 to 50e7545 Compare August 13, 2024 20:59

github-actions bot reviewed Aug 13, 2024

View reviewed changes

Update action.yml

31f42b9

github-actions bot reviewed Aug 13, 2024

View reviewed changes

Update action.yml

acfc361

github-actions bot reviewed Aug 13, 2024

View reviewed changes

vercel bot deployed to Preview August 13, 2024 22:38 View deployment

Update docker-unified.yml

f594525

vercel bot deployed to Preview August 13, 2024 22:59 View deployment

Update docker-unified.yml

c01240b

vercel bot deployed to Preview August 13, 2024 23:32 View deployment

Merge branch 'master' into github-actions-1

081e625

vercel bot deployed to Preview August 13, 2024 23:54 View deployment

david-leifker merged commit 18ce104 into master Aug 14, 2024
51 of 52 checks passed

david-leifker deleted the github-actions-1 branch August 14, 2024 00:14

feat(actions): updates to gha workflows #11150

feat(actions): updates to gha workflows #11150

Conversation

david-leifker commented Aug 12, 2024

Checklist

coderabbitai bot commented Aug 12, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 12, 2024

Choose a reason for hiding this comment

github-actions bot Aug 12, 2024

Choose a reason for hiding this comment

github-actions bot Aug 12, 2024

Choose a reason for hiding this comment

github-actions bot Aug 12, 2024

Choose a reason for hiding this comment

github-actions bot Aug 12, 2024

Choose a reason for hiding this comment

github-actions bot Aug 12, 2024

Choose a reason for hiding this comment

github-actions bot Aug 12, 2024

Choose a reason for hiding this comment

github-actions bot Aug 12, 2024

Choose a reason for hiding this comment

github-actions bot Aug 12, 2024

Choose a reason for hiding this comment

github-actions bot Aug 12, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

CodeRabbit Configuration File (`.coderabbit.yaml`)