-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(ingest/dbt): update run result paths examples #11138
Conversation
WalkthroughThe recent changes enhance the flexibility of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
metadata-ingestion/docs/sources/dbt/dbt_recipe.yml (1)
9-10
: Clarify the comment forrun_results_paths
.The comment indicates that the path is optional for recording dbt test results, but now that it's a list, consider clarifying whether all paths are optional or if at least one is required.
run_results_paths: - "${DBT_PROJECT_ROOT}/target/run_results.json" # optional for recording dbt test results; specify multiple paths if needed
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- metadata-ingestion/docs/sources/dbt/dbt.md (3 hunks)
- metadata-ingestion/docs/sources/dbt/dbt_recipe.yml (1 hunks)
- metadata-ingestion/tests/integration/dbt/test_dbt.py (3 hunks)
Additional comments not posted (6)
metadata-ingestion/docs/sources/dbt/dbt.md (3)
174-174
: Ensure consistency in parameter updates.The documentation correctly reflects the changes from
test_results_path
torun_results_paths
. Ensure all instances of the old parameter are updated throughout the document to maintain consistency.
218-219
: Confirm the example configuration reflects the new parameter.The example configuration now uses
run_results_paths
. Ensure that users are aware of the new list format and that existing configurations are updated accordingly.
233-234
: Verify all configuration examples are updated.The configuration examples have been updated to use
run_results_paths
. Double-check that all examples throughout the documentation reflect this change to prevent user confusion.metadata-ingestion/tests/integration/dbt/test_dbt.py (3)
449-455
: Ensure comprehensive testing forrun_results_paths
.The test function now uses
run_results_paths
. Verify that the tests adequately cover the functionality of handling multiple paths.
342-348
: Verify test coverage for multiple paths.The
run_results_paths
parameter is now a list. Ensure that the tests cover scenarios with multiple paths to validate the new functionality.
529-535
: Confirm multiple path handling in tests.The
run_results_paths
parameter is used in this test. Double-check that the tests cover scenarios involving multiple paths to ensure robustness.
Checklist
Summary by CodeRabbit
New Features
run_results_paths
parameter.Documentation
Bug Fixes