-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(data product): Update example and docs #11032
Conversation
WalkthroughThe recent changes enhance the DataHub documentation and metadata by clarifying the domain name resolution process and adding a new ownership entry. This improves user understanding of domain handling across multiple fields and refines ownership classification for data products, ultimately facilitating better management and tracking of responsibilities. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
metadata-ingestion/examples/data_product/dataproduct.yaml (1)
16-17
: The custom ownership typeurn:li:ownershipType:architect
is not recognized by the system.Ensure that the custom ownership type is defined and registered in the appropriate configuration or service files.
- The custom ownership type
urn:li:ownershipType:architect
is only present in thedataproduct.yaml
file and not defined elsewhere in the codebase.Analysis chain
LGTM! Verify the custom ownership type.
The addition of a new owner with a custom ownership type enhances the granularity of ownership classification.
However, ensure that the custom ownership type
urn:li:ownershipType:architect
is recognized by the system.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the custom ownership type `urn:li:ownershipType:architect` is recognized by the system. # Test: Search for the custom ownership type definition. Expect: Definition of `urn:li:ownershipType:architect`. rg --type yaml 'urn:li:ownershipType:architect'Length of output: 181
Script:
#!/bin/bash # Description: Verify where ownership types are defined or registered in the system. # Test: Search for the term 'ownershipType' across the codebase to find where ownership types are defined or registered. rg 'ownershipType'Length of output: 53215
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- docs/dataproducts.md (1 hunks)
- metadata-ingestion/examples/data_product/dataproduct.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/dataproducts.md
Checklist
Summary by CodeRabbit
Documentation
New Features