Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bug fix for empty key values pair in elastic search mapping #11004

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fix: bug fix for empty key values pair in elastic search mapping #11004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e9ca9b
Fix: bug fix for empty key values pair in elastic search mapping
Jul 26, 2024
fcc5c43
Fix: added unit tests for empty key values pair
Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...-io/src/main/java/com/linkedin/metadata/search/transformer/SearchDocumentTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,10 @@ public void setSearchableValue(
.forEach(
fieldValue -> {
String[] keyValues = fieldValue.toString().split("=");
String key = keyValues[0];
String value = keyValues[1];
String key = keyValues[0], value = "";
if (keyValues.length > 1) {
value = keyValues[1];
}
dictDoc.put(key, value);
});
searchDocument.set(fieldName, dictDoc);
Expand Down
2 changes: 2 additions & 0 deletions metadata-io/src/test/java/com/linkedin/metadata/TestEntityUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ public static TestEntityInfo getTestEntityInfo(Urn urn) {
"value1",
"key2",
"value2",
"key3",
"",
"shortValue",
"123",
"longValue",
Expand Down
8 changes: 3 additions & 5 deletions metadata-io/src/test/java/com/linkedin/metadata/extractor/FieldExtractorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ public void testExtractor() {
ImmutableList.of("key1=value1", "key2=value2", "shortValue=123", "longValue=0123456789"));
assertEquals(
result.get(nameToSpec.get("esObjectField")),
ImmutableList.of("key1=value1", "key2=value2", "shortValue=123", "longValue=0123456789"));
ImmutableList.of(
"key1=value1", "key2=value2", "shortValue=123", "key3=", "longValue=0123456789"));
}

@Test
Expand Down Expand Up @@ -99,9 +100,6 @@ public void testExtractorMaxValueLength() {
result.get(nameToSpec.get("customProperties")),
ImmutableList.of(),
"Expected no matching values because of value limit of 1");
assertEquals(
result.get(nameToSpec.get("esObjectField")),
ImmutableList.of(),
"Expected no matching values because of value limit of 1");
assertEquals(result.get(nameToSpec.get("esObjectField")), ImmutableList.of("key3="));
}
}
5 changes: 4 additions & 1 deletion ...src/test/java/com/linkedin/metadata/search/transformer/SearchDocumentTransformerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public void testTransform() throws IOException {
assertEquals(parsedJson.get("feature2").asInt(), 1);
JsonNode browsePathV2 = (JsonNode) parsedJson.get("browsePathV2");
assertEquals(browsePathV2.asText(), "␟levelOne␟levelTwo");
assertEquals(parsedJson.get("esObjectField").get("key3").asText(), "");
}

@Test
Expand Down Expand Up @@ -125,7 +126,8 @@ public void testTransformMaxFieldValue() throws IOException {
assertEquals(
parsedJson.get("customProperties"),
JsonNodeFactory.instance.arrayNode().add("shortValue=123"));
assertEquals(parsedJson.get("esObjectField"), JsonNodeFactory.instance.arrayNode().add("123"));
assertEquals(
parsedJson.get("esObjectField"), JsonNodeFactory.instance.arrayNode().add("123").add(""));

searchDocumentTransformer = new SearchDocumentTransformer(1000, 1000, 20);
snapshot = TestEntityUtil.getSnapshot();
Expand All @@ -149,6 +151,7 @@ public void testTransformMaxFieldValue() throws IOException {
.add("value1")
.add("value2")
.add("123")
.add("")
.add("0123456789"));
}

Expand Down
Loading