feat(ingest/snowflake): allow iceberg tables in lineage and access metadata

[alisa-aylward-toast]

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Despite not having in their documentation, Iceberg table is a valid object domain in Snowflake access history. We want to capture this for lineage purposes so any table downstream of an Iceberg table is included in lineage.

Summary by CodeRabbit

• New Features

  • Introduced support for Iceberg tables in Snowflake object handling, expanding the types of objects that can be processed.
  • Updated SQL queries to include Iceberg tables, allowing broader data analysis and processing capabilities.

• Bug Fixes

  • Adjusted queries to ensure accurate data retrieval for Iceberg tables alongside existing object types.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update introduces the ICEBERG_TABLE constant to the SnowflakeObjectDomain enumeration and extends the SnowflakeQuery class to accommodate Iceberg tables. Additionally, it modifies a SQL query to include Iceberg tables in its filtering criteria. These enhancements improve the handling of Snowflake objects and broaden the scope of data processing capabilities, enabling better integration with emerging data storage formats.

Changes

Files	Change Summary
.../snowflake/constants.py, .../snowflake/snowflake_query.py	Added ICEBERG_TABLE to SnowflakeObjectDomain and updated SnowflakeQuery to handle Iceberg tables.
.../snowflake/common.py	Modified SQL query to include Iceberg tables in the filtering criteria for basic_usage_counts.object_domain.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SnowflakeObjectDomain
    participant SnowflakeQuery
    participant SQLExecution

    User->>SnowflakeObjectDomain: Request Object Types
    SnowflakeObjectDomain-->>User: Return Types (including ICEBERG_TABLE)
    
    User->>SnowflakeQuery: Construct Query for ICEBERG_TABLE
    SnowflakeQuery->>SQLExecution: Execute Query for ICEBERG_TABLE
    SQLExecution-->>SnowflakeQuery: Return Results
    SnowflakeQuery-->>User: Provide Results

Loading

Poem

🐰 In the land of data where we hop and play,
The Iceberg tables join us on this day.
With queries a'flowing and constants anew,
We're ready for processing, oh what a view!
So let’s dance in the fields, as we analyze cheer,
For more data wonders, we're never in fear! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9f570a7 and 300df65.

Files selected for processing (3)

• metadata-ingestion/src/datahub/ingestion/source/snowflake/constants.py (1 hunks)
• metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_query.py (1 hunks)
• metadata-ingestion/tests/integration/snowflake/common.py (1 hunks)

Additional comments not posted (3)

metadata-ingestion/src/datahub/ingestion/source/snowflake/constants.py (1)

55-55: Add ICEBERG_TABLE to SnowflakeObjectDomain Enum

The addition of ICEBERG_TABLE to the SnowflakeObjectDomain enumeration is correct and consistent with the existing code. This change enhances the functionality by recognizing Iceberg tables.

metadata-ingestion/tests/integration/snowflake/common.py (1)

159-159: Include Iceberg table in SQL query

The modification to include 'Iceberg table' in the filtering criteria of the SQL query is correct and aligns with the intended functionality of recognizing Iceberg tables in the lineage and access metadata.

metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_query.py (1)

38-38: Add ICEBERG_TABLE to SnowflakeQuery Domains

The addition of ICEBERG_TABLE to the set of domains in the SnowflakeQuery class is correct and consistent with the existing code. This change enhances the functionality by recognizing Iceberg tables.

[alisa-aylward-toast]

@mayurinehate any feedback on this?

[mayurinehate]

LGTM

[alisa-aylward-toast]

@eboneil or @hsheth2 do you know how i could find a maintainer to review?

[hsheth2]

Sorry about the delay here - we needed to check if there were any side effects that this would have, but I think we're all good