Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure_ad): fix infinite loop on request error #10679

Conversation

darnaut
Copy link
Collaborator

@darnaut darnaut commented Jun 11, 2024

The Azure AD ingestion goes into an infinite loop if a request returns a response code other than 200. This changes the request to retry up to 5 times and only for retriable error codes.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jun 11, 2024
@darnaut darnaut force-pushed the fix-ingestion-azure-ad-infinite-loop-on-error branch 2 times, most recently from 97c86ec to a7eb731 Compare June 11, 2024 18:12
@darnaut darnaut force-pushed the fix-ingestion-azure-ad-infinite-loop-on-error branch from a7eb731 to 56c53a5 Compare June 11, 2024 18:32
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jun 11, 2024
@darnaut darnaut merged commit 52ac314 into datahub-project:master Jun 11, 2024
75 of 82 checks passed
@darnaut darnaut deleted the fix-ingestion-azure-ad-infinite-loop-on-error branch June 11, 2024 20:41
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants