perf(ingestion/fivetran): Connector performance optimization #10556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
reviewed
May 21, 2024
| @@ -66,7 +66,7 @@ class FivetranSource(StatefulIngestionSourceBase): | |||
| platform: str = "fivetran" | |||
|
|
|||
| def __init__(self, config: FivetranSourceConfig, ctx: PipelineContext): | |||
| super().__init__(config, ctx) | |||
| super(FivetranSource, self).__init__(config, ctx) | |||
There was a problem hiding this comment.
Changes happen automatically. Let me revert it
| @@ -76,7 +77,7 @@ def _initialize_fivetran_variables( | |||
| ) | |||
|
|
|||
| def _query(self, query: str) -> List[Dict]: | |||
| logger.debug(f"Query : {query}") | |||
| logger.debug("Query : {}".format(query)) | |||
There was a problem hiding this comment.
Changes happen automatically. Let me revert it
| SELECT connector_id, | ||
| sync_id, | ||
| message_event, | ||
| message_data, | ||
| time_stamp | ||
| FROM {self.db_clause}log | ||
| WHERE message_event in ('sync_start', 'sync_end')""" | ||
| FROM {}log |
There was a problem hiding this comment.
use named format args
e.g. "{foo}".format(foo='whatever')
…ance-optimization
hsheth2
reviewed
May 23, 2024
metadata-ingestion/src/datahub/ingestion/source/fivetran/config.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/fivetran/config.py
Outdated
Show resolved
Hide resolved
…into Fivetran-connector-performance-optimization
hsheth2
reviewed
Jun 5, 2024
| @@ -208,50 +214,61 @@ def _get_jobs_list( | |||
| ) | |||
| return jobs | |||
|
|
|||
| def _get_user_email(self, user_id: Optional[str]) -> Optional[str]: | |||
| @functools.lru_cache() | |||
| def get_user_email(self, user_id: str) -> Optional[str]: | |||
| if not user_id: | |||
| return None | |||
| user_details = self._query( | |||
| self.fivetran_log_query.get_user_query(user_id=user_id) | |||
There was a problem hiding this comment.
is this sending one query per user? ideally this would also do a bulk fetch
metadata-ingestion/src/datahub/ingestion/source/state/stale_entity_removal_handler.py
Show resolved
Hide resolved
hsheth2
approved these changes
Jun 6, 2024
hsheth2
added
the
merge-pending-ci
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
yoonhyejin
pushed a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist