fix(ci): unified workflow login logic #10235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.github/workflows/docker-unified.yml
Outdated
| @@ -859,6 +883,7 @@ jobs: | |||
| ./gradlew :metadata-ingestion:install | |||
| - name: Login to DockerHub | |||
| uses: docker/login-action@v2 | |||
| if: ${{ secrets.ACRYL_DOCKER_PASSWORD != '' }} | |||
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
context "secrets" is not allowed here. available contexts are "env", "github", "inputs", "job", "matrix", "needs", "runner", "steps", "strategy", "vars". see https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability for more details [expression]
david-leifker
force-pushed
the
unified-workflow-update-1
branch
from
654784b to
941be5f
Compare
| id: docker-login | ||
| env: | ||
| ENABLE_DOCKER_LOGIN: ${{ secrets.ACRYL_DOCKER_PASSWORD != '' }} | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting [shellcheck]
david-leifker
force-pushed
the
unified-workflow-update-1
branch
from
941be5f to
b57f57b
Compare
darnaut
approved these changes
Apr 8, 2024
This was referenced Apr 8, 2024
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist