Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Superset: ingestion of the empty dashboard fails #3713

Closed
grumbler opened this issue Dec 10, 2021 · 1 comment
Closed

Superset: ingestion of the empty dashboard fails #3713

grumbler opened this issue Dec 10, 2021 · 1 comment
Labels
bug Bug report

Comments

@grumbler
Copy link
Contributor

When dashboard is empty and doesn't contain any charts ingestion fails here:

        raw_position_data = dashboard_data.get("position_json", "{}")
        position_data = json.loads(raw_position_data)

position_json is None in this case

Expected behavior

Import empty dashboard without charts
@grumbler grumbler added the bug Bug report label Dec 10, 2021
grumbler added a commit to grumbler/datahub that referenced this issue Dec 10, 2021
@grumbler
fix(superset): handle dashboards without charts (datahub-project#3713)
7f7d4a6
shirshanka pushed a commit that referenced this issue Dec 13, 2021
@grumbler
fix(superset): handle dashboards without charts (#3713) (#3714)
83207b3
@shirshanka
Copy link
Contributor

Fixed via #3714 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grumbler @shirshanka