Skip to content

Commit

Permalink
feat(platform): add "postgres" as a supported data platform (#1859)
Browse files Browse the repository at this point in the history
* feat(platform): add "postgres" as a supported data platform

* update tests
  • Loading branch information
mars-lan authored Sep 8, 2020
1 parent 340c543 commit f0485a4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions gms/impl/src/main/resources/DataPlatformInfo.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@
"name": "pinot",
"type": "OLAP_DATASTORE"
},
"urn:li:dataPlatform:postgres": {
"datasetNameDelimiter": ".",
"name": "postgres",
"type": "RELATIONAL_DB"
},
"urn:li:dataPlatform:presto": {
"datasetNameDelimiter": ".",
"name": "presto",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public void testGetPlatformType() {
assertPlatformType("oracle", PlatformType.RELATIONAL_DB);
assertPlatformType("pinot", PlatformType.OLAP_DATASTORE);
assertPlatformType("presto", PlatformType.QUERY_ENGINE);
assertPlatformType("postgres", PlatformType.RELATIONAL_DB);
assertPlatformType("teradata", PlatformType.RELATIONAL_DB);
assertPlatformType("voldemort", PlatformType.KEY_VALUE_STORE);
}
Expand Down Expand Up @@ -70,6 +71,7 @@ public void testGetPlatformDelimiter() {
assertEquals(DataPlatformsUtil.getPlatformDelimiter("oracle").get(), ".");
assertEquals(DataPlatformsUtil.getPlatformDelimiter("pinot").get(), ".");
assertEquals(DataPlatformsUtil.getPlatformDelimiter("presto").get(), ".");
assertEquals(DataPlatformsUtil.getPlatformDelimiter("postgres").get(), ".");
assertEquals(DataPlatformsUtil.getPlatformDelimiter("teradata").get(), ".");
assertEquals(DataPlatformsUtil.getPlatformDelimiter("voldemort").get(), ".");
assertFalse(DataPlatformsUtil.getPlatformDelimiter("fake").isPresent());
Expand Down

0 comments on commit f0485a4

Please sign in to comment.