power favicon via env var

datahub-project · Sep 1, 2022 · 788de40 · 788de40
1 parent 9afda47
commit 788de40
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 0 deletions.
diff --git a/...l-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java b/...l-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java
@@ -115,6 +115,7 @@ public CompletableFuture<AppConfig> get(final DataFetchingEnvironment environmen
     final VisualConfig visualConfig = new VisualConfig();
     if (_visualConfiguration != null && _visualConfiguration.getAssets() != null) {
       visualConfig.setLogoUrl(_visualConfiguration.getAssets().getLogoUrl());
+      visualConfig.setFaviconUrl(_visualConfiguration.getAssets().getFaviconUrl());
     }
     appConfig.setVisualConfig(visualConfig);
 

diff --git a/datahub-graphql-core/src/main/resources/app.graphql b/datahub-graphql-core/src/main/resources/app.graphql
@@ -167,6 +167,11 @@ type VisualConfig {
   Custom logo url for the homepage & top banner
   """
   logoUrl: String
+
+  """
+  Custom favicon url for the homepage & top banner
+  """
+  faviconUrl: String
 }
 
 """

diff --git a/datahub-web-react/src/AppConfigProvider.tsx b/datahub-web-react/src/AppConfigProvider.tsx
@@ -5,6 +5,16 @@ import { checkAuthStatus } from './app/auth/checkAuthStatus';
 import { AppConfigContext, DEFAULT_APP_CONFIG } from './appConfigContext';
 import { useAppConfigQuery } from './graphql/app.generated';
 
+function changeFavicon(src) {
+    let link = document.querySelector("link[rel~='icon']") as any;
+    if (!link) {
+        link = document.createElement('link');
+        link.rel = 'icon';
+        document.getElementsByTagName('head')[0].appendChild(link);
+    }
+    link.href = src;
+}
+
 const AppConfigProvider = ({ children }: { children: React.ReactNode }) => {
     const { data: appConfigData, refetch } = useAppConfigQuery();
 
@@ -20,6 +30,7 @@ const AppConfigProvider = ({ children }: { children: React.ReactNode }) => {
             } else {
                 localStorage.setItem(THIRD_PARTY_LOGGING_KEY, 'false');
             }
+            changeFavicon(appConfigData.appConfig.visualConfig.faviconUrl);
         }
     }, [appConfigData]);
 

diff --git a/datahub-web-react/src/graphql/app.graphql b/datahub-web-react/src/graphql/app.graphql
@@ -36,6 +36,7 @@ query appConfig {
         }
         visualConfig {
             logoUrl
+            faviconUrl
         }
         telemetryConfig {
             enableThirdPartyLogging

diff --git a/metadata-io/src/main/java/com/linkedin/metadata/config/AssetsConfiguration.java b/metadata-io/src/main/java/com/linkedin/metadata/config/AssetsConfiguration.java
@@ -9,4 +9,5 @@ public class AssetsConfiguration {
    * The url of the logo to render in the DataHub Application.
    */
   public String logoUrl;
+  public String faviconUrl;
 }
diff --git a/metadata-service/factories/src/main/resources/application.yml b/metadata-service/factories/src/main/resources/application.yml
@@ -92,6 +92,7 @@ platformAnalytics:
 visualConfig:
   assets:
     logoUrl: ${REACT_APP_LOGO_URL:/assets/platforms/datahublogo.png}
+    faviconUrl: ${REACT_APP_FAVICON_URL:/assets/favicon.ico}
 
 # Storage Layer