use glue for pastes

dataheld · Sep 12, 2024 · 29850a5 · 29850a5
1 parent f90d2ab
commit 29850a5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -28,6 +28,7 @@ Imports:
     checkmate,
     cli,
     fs,
+    glue,
     options,
     pkgload,
     purrr,

diff --git a/R/installed.R b/R/installed.R
@@ -18,7 +18,7 @@ check_pkg_installed <- function(x = character(1L)) {
   if (rlang::is_installed(x)) {
     return(TRUE)
   } else {
-    paste("Package", x, "is not installed.")
+    glue::glue("Package {x} is not installed")
   }
 }
 
@@ -78,10 +78,8 @@ check_pkg_installed_but_not_via_loadall <- function(x = character(1L)) {
     return(res)
   }
   if (pkgload::is_dev_package(x)) {
-    paste(
-      "The version of package",
-      x,
-      "was loaded from `pkgload::load_all()`.",
+    glue::glue(
+      "The version of package {x} was loaded from `pkgload::load_all()`.",
       "It is not the installed version."
     )
   } else {

diff --git a/tests/testthat/test-installed.R b/tests/testthat/test-installed.R
@@ -7,7 +7,7 @@ describe("check_pkg_installed", {
     "returns message for non-installed packages",
     expect_equal(
       check_pkg_installed("doNOTexist"),
-      "Package doNOTexist is not installed."
+      "Package doNOTexist is not installed"
     )
 
   )
-Original file line number
+Diff line change
@@ Expand Up / @@ -28,6 +28,7 @@ Imports: @@
         checkmate,
         cli,
         fs,
+        glue,
         options,
         pkgload,
         purrr,
@@ Expand Down @@