Implement native schema inference for PostgreSQL #151
Merged
+1,332
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plan to cherry-pick this commit to |
sgrebnov
approved these changes
Oct 23, 2024
|
Will need to investigate these upstream errors before merging this PR: https://github.com/spiceai/spiceai/actions/runs/11484314326/job/31961830960 |
Sevenannn
approved these changes
Oct 23, 2024
phillipleblanc
added a commit
that referenced
this pull request
Oct 24, 2024
* wip * test cleanup * Implement native schema inference for PostgreSQL * handle bpchar * fix uuid * Fix test * align * fix snapshot
phillipleblanc
added a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127
This PR implements native schema inference for PostgreSQL using a combination of postgres native system tables and
information_schema. It handles all primitive types, array types, complex types and enums. It also handles quite a few types that the row conversion itself doesn't support yet - but those can be added over time (i.e.TSVECTOR,INET,CIDR,MACADDR,UUID,JSON,JSONB,XML).This allows the schema to be retrieved even for tables without any rows.