This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
ci: test against more compilers, setup clippy and fix clippy lints #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cpcloud
commented
Jan 7, 2022
cpcloud
commented
- Use cargo flags to prevent out-of-date Cargo.lock
- Ship the Cargo.lock file in the source distribution
- ci: add more variations to ci
cpcloud
changed the title
|
Thanks @cpcloud - i've incorporated some of your changes already, please rebase first? |
|
@jimexist done! |
jimexist
reviewed
Jan 13, 2022
Comment on lines
+40
to
+41
| - beta | ||
| - nightly |
There was a problem hiding this comment.
wonder if we need to run against nightly and beta
There was a problem hiding this comment.
usually if you run against all of them there will be conflicting fmt changes
There was a problem hiding this comment.
The format check is only against stable
jimexist
approved these changes
Jan 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.